Change Factory loading mechanism to FactoryBots supported mechanism #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
factorybot-fixes-5.2
branch
from
eb9d45a to
099e803
Compare
We build these factories such that they could be independently loaded. However, FactoryBot is built with the assumption in mind that it gets a number of folder names and loads the factories when loading itself (via FactoryBot.find_definitions). The old behaviour is still supported, but deprecated.
mamhoff
force-pushed
the
factorybot-fixes-5.2
branch
from
099e803 to
becaa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build these factories such that they could be independently loaded.
However, FactoryBot is built with the assumption in mind that it gets a
number of folder names and loads the factories when loading itself (via
FactoryBot.find_definitions).
The old behaviour is partially still supported, but deprecated.